Update LoRA developer guides: non-in-place operations #2871
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBossan
requested changes
Oct 27, 2025
docs/source/developer_guides/lora.md
Outdated
| peft_model_id = "alignment-handbook/zephyr-7b-sft-lora" | ||
| model = PeftModel.from_pretrained(base_model, peft_model_id) | ||
| model.merge_and_unload() | ||
| merged_model = model.merge_and_unload() |
There was a problem hiding this comment.
Let's assign to the same variable. This is because after calling merge_and_unload, the original model shouldn't be used anymore.
Suggested change
| merged_model = model.merge_and_unload() | |
| model = model.merge_and_unload() |
There was a problem hiding this comment.
Thanks for the comment, @BenjaminBossan, I made the change you suggested and uploaded it. Let me know if you think there is anything else that should change!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of the merge_and_unload() function clarifies that this is not an in-place operation. However, the developer guides code snippets shows
which do not match the function documentation. The same happens with the unload() function.
This PR just changes it to be consistent and minimize silent mistakes when using the guides!